Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSCE-251: refactor(cli): removes reusable CLI code to cli_base to enable multip… #54

Merged
merged 2 commits into from
Oct 9, 2023

Conversation

jpower432
Copy link
Member

@jpower432 jpower432 commented Oct 5, 2023

…le entrypoints

Description

Adds a cli_base to allow flags and logic to be reused with different entry point implementations.
This intentionally does not include subparsers as we want to reuse the logic with individual entrypoints, but not create a hierarchical command structure.

Type of change

  • Refactor

How has this been tested?

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@jpower432 jpower432 requested a review from afflom October 6, 2023 17:18
@afflom afflom merged commit 1f01c71 into RedHatProductSecurity:main Oct 9, 2023
7 checks passed
jpower432 added a commit to jpower432/trestle-bot that referenced this pull request Oct 9, 2023
…ble multip… (RedHatProductSecurity#54)

* refactor(cli): removes reusable CLI code to cli_base to enable multiple entrypoints

Signed-off-by: Jennifer Power <[email protected]>

* chore: adds comment fixes in cli_base

Signed-off-by: Jennifer Power <[email protected]>

---------

Signed-off-by: Jennifer Power <[email protected]>
@jpower432 jpower432 mentioned this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants